Fix simulator test failures on main#13608
Conversation
boring-cyborg
Bot
added
component:integration-test
Python
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13608 +/- ##
=========================================
Coverage 19.50% 19.50%
+ Complexity 19441 19439 -2
=========================================
Files 6303 6303
Lines 569288 569286 -2
Branches 69792 69791 -1
=========================================
+ Hits 111029 111030 +1
+ Misses 446108 446103 -5
- Partials 12151 12153 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
thanks a lot @harikrishna-patnala @blueorangutan package |
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
makes perfect sense
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18561 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
There was a problem hiding this comment.
Pull request overview
This PR updates CloudStack’s VPC-offering validation and integration test expectations to align with current service support rules, addressing simulator test failures observed on the main branch.
Changes:
- Update the VPC offering integration test to use
SecurityGroupas an invalid VPC service (instead ofFirewall). - Adjust network offering creation logic so
Firewallno longer implicitly classifies an offering as “for VPC”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/integration/component/test_vpc_offerings.py | Fixes the invalid-service VPC offering test case to assert failure on SecurityGroup service. |
| server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java | Removes Firewall from the implicit “for VPC” inference logic during network offering creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
CI results look fine. merging this, I will run smoke tests with other PRs (see #12198) thanks @harikrishna-patnala for the fix, and @sureshanaparti for the review |
Description
This PR fixes the below failures seen on main branch health check PR #12198
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?